Deploy and test fee contracts #403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…rom 5 USDC to 1000 (it's testnet USDC anyway)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces deployment infrastructure for fee contracts and comprehensive E2E testing for the Lit Action-based owner attestation signing system. The implementation enables cross-chain verification of app ownership using Lit Protocol's PKP (Programmable Key Pairs) and integrates with Chronicle Yellowstone and Base Sepolia testnets.
Key Changes
- Deployment scripts with environment variable validation for fee contracts across networks
- E2E test validating the complete flow from app creation to fee withdrawal using real testnets
- Lit Action bundling and deployment infrastructure with IPFS integration
Reviewed Changes
Copilot reviewed 32 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pnpm-lock.yaml |
Updated dependencies with Lit Protocol packages moved between dev/prod dependencies |
packages/libs/contracts-sdk/package.json |
Added Lit Protocol client packages, esbuild, dotenv, and ipfs-only-hash |
packages/libs/contracts-sdk/src/fees/signOwnerAttestation.ts |
TypeScript wrapper for executing Lit Actions to sign owner attestations |
packages/libs/contracts-sdk/lit-actions/ |
Lit Action source code for reading Vincent contract and signing attestations |
packages/libs/contracts-sdk/scripts/fees/deploy_fee_contracts.sh |
Bash script for deploying fee contracts with environment validation |
packages/libs/contracts-sdk/scripts/deploy-lit-action.js |
JavaScript script to bundle and deploy Lit Actions to IPFS |
packages/libs/contracts-sdk/test/fees/signOwnerAttestation.e2e.spec.ts |
Comprehensive E2E test validating the complete fee withdrawal flow |
packages/libs/contracts-sdk/script/DeployFeeDiamond.sol |
Updated Solidity deployment script to accept Vincent Diamond address |
packages/libs/contracts-sdk/test/fees/FeeTestCommon.sol |
Added documentation for mock attestation signing vs. production Lit Action |
packages/libs/contracts-sdk/esbuild.lit-actions.config.js |
esbuild configuration for bundling Lit Actions with polyfills |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
glitch003
requested review from
Ansonhkg,
DashKash54,
FedericoAmura,
MaximusHaximus,
awisniew207 and
spacesailor24
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deployment script for fee contracts, oracle lit action + deployment script, and e2e test on base sepolia, using aave, with a lit action test of withdrawal from it both by the lit foundation and the app owner.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
pnpx nx run contracts-sdk:test-e2e:fees --verbosewill run e2e tests that deposit to aave through the fee contracts on base sepolia, waits 60 sec for profit to accrue, then withdraws from aave. and then the app owner withdraws their fee (90% of the whole fee), and we withdraw our platform fee (10% of the whole fee)Checklist:
nx release plan) describing my changes and the version bump